0 votes
1 view
in Salesforce by (11.9k points)

I have not been able to get any reliable information about this issue online. But I think it must be an issue which must be affecting a lot of people.

Basically I wrote a simple trigger and test class in sandbox, tested it and when it was fine I deployed it to PRD.

I tried the validation mode first and I got this error.

System.LimitException: Too many SOQL queries: 101

This error was shown to occur in some other test class. So I feel that the test cases in my trigger ran and this coupled with the remaining test cases somehow overshot the limit.

So the total number of SOQL queries in our unit tests must be less than 100. This is a little hard to adere to right? I can imagine with so many test cases, surely we will need more than 100 queries.

So what are the ways to avoid hitting this limit because Salesforce runs all the test cases when deploying even a single line of code.

I don't not have any of the usual suspects...like SOQL within a for loop.

Source code of the test class and trigger

Test Class:

@isTest

private class TestAccountDuplicateWebsiteTrigger {

static testMethod void myUnitTest() {

    try{

    // TO DO: implement unit test

    Test.startTest();

    Account a1;      

    a1 = new Account();

    a1.name = 'GMSTest';    

    a1.Website = 'www.test.com';            

    Account a2;      

    a2 = new Account();

    a2.name = 'GMSTest2';   

    a2.Website = 'www.test.com';            

    Account a3;      

    a3 = new Account();

    a3.name = 'GMSTest3';   

    a3.Website = 'www.test1.com';           

    insert a1;

    insert a2;

    //insert a3;

    Test.stopTest(); 

    }

    catch (Exception e)

    {

    }

}

}

Trigger

trigger osv_unique_website_for_account on Account (before insert, before update) {  

    //Map which has no duplicates with website as the key

    Map<String, Account> accountMap = new Map<String, Account>();

    for (Account account: System.Trigger.new)

    {

        //Ensure that during an update, if an website does not change - it should not be treated as a duplicate

        if ((account.Website != null) && (System.Trigger.isInsert ||            

            (account.Website != System.Trigger.oldMap.get(account.Id).Website))) 

            {

                //check for duplicates among the new accounts in case of a batch

                 if (accountMap.containsKey(account.Website)) 

                 {

                    account.Website.addError('Cannot save account. Website already exists.');

                 } 

                 else 

                 {

                    accountMap.put(account.Website, account);

                 }

            }       

    }

    //Now map containing new account websites has been created. 

    //Check them against the account websites that ALREADY EXIST in salesforce. If website exists, display error.

    for (Account account : [SELECT Website FROM Account WHERE Website IN :accountMap.KeySet()]) 

    {

        Account newAccount = accountMap.get(Account.Website);

        if (newAccount!=null)

        {

            newAccount.Website.addError('Cannot save account. Website already exists.');

        }

    }   

}

Can you please share your thoughts?

1 Answer

0 votes
by (30.1k points)

Looking at some of your test classes might be helpful but one major thing to note is that you need to make use to Test.startTest() and Test.stopTest() methods. The intention is that any queries or DML operations that you do to set up your test should be down before the Test.startTest() method. Then when testing your code such as executing a method you are testing do that between the start and stop method calls.

This gives the unit test context. This will essentially ignore any DML or queries done outside of your start and stop testing and only count what appears within as part of your test. Otherwise, all setup code and actual test code are all considered part of the same context and thus subject to be counted towards the limits.

Welcome to Intellipaat Community. Get your technical queries answered by top developers !


Categories

...